Add call actions #634
Merged
Add call actions #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolve #608 |
Closed
Allow admin call to call as reserved address.
|
Fixed some issues, now the call/admincall action can create contracts. admincall can also call as reserved address. |
reverted call/admincall action.
yarkinwho
changed the title
arhag
requested changes
Aug 8, 2023
arhag
requested changes
Aug 10, 2023
There was a problem hiding this comment.
Just one small change remaining and then also the unit test described in #634 (comment).
elmato
reviewed
Aug 10, 2023
elmato
reviewed
Aug 11, 2023
elmato
approved these changes
Aug 14, 2023
arhag
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary implementation of the call function.
Including two actions:
1 call, must be called by some eos account, and will send transaction on behalf of the caller
2 admincall, must be called by the evm account (controlled by multisig e.g.), allow send transaction on behalf of any account. It should only be used by recovery +
pending submodule update